rust-lang / backtrace-rs

Backtraces in Rust
https://docs.rs/backtrace
Other
516 stars 237 forks source link

Fix tests for rust 1.79 #621

Closed workingjubilee closed 2 months ago

workingjubilee commented 2 months ago
workingjubilee commented 2 months ago

The sweet irony of "it won't actually work until its committed".

workingjubilee commented 2 months ago

I suppose there is a way to fix it, actually...

ChrisDenton commented 2 months ago

Looks good. Are there any docs for collapse_debuginfo yet?

ChrisDenton commented 2 months ago

Btw, it's just check_cfg that's failing.

workingjubilee commented 2 months ago

@Urgau It caught like two things that it should have caught and I almost missed them because it was squawking irrelevantly on all the nonsense like --cfg backtrace_in_libstd.

workingjubilee commented 2 months ago

I didn't design this crate's silliness, I just keep it running.

workingjubilee commented 2 months ago

@ChrisDenton It looks like there's only one for the associated codegen option:

https://github.com/rust-lang/rust/blob/31110152e2b3ce3c009be4a0a13edaff7c008b61/src/doc/rustc/src/codegen-options/index.md?plain=1#L45-L55

workingjubilee commented 2 months ago

Ah, found it: https://github.com/rust-lang/reference/pull/1468

ChrisDenton commented 2 months ago

Thank you!

Urgau commented 2 months ago

@Urgau It caught like two things that it should have caught and I almost missed them because it was squawking irrelevantly on all the nonsense like --cfg backtrace_in_libstd.

@workingjubilee This crate has already many build.rs, you could have simply added the required cargo::check-check-cfg instructions in it.

workingjubilee commented 2 months ago

@Urgau I intend to delete this crate's main build.rs, so no.

workingjubilee commented 2 months ago

@Urgau This crate only has a build.rs because Rust currently has tail-end Android legacy support that is not actually supported anymore upstream by the NDK. So, rust-lang/rust has a PR up to remove it, but that is blocked on rust's own CI. This crate never should have had a build.rs, and that will soon be fixed for good, and I will not merge another.