Closed workingjubilee closed 2 months ago
The sweet irony of "it won't actually work until its committed".
I suppose there is a way to fix it, actually...
Looks good. Are there any docs for collapse_debuginfo
yet?
Btw, it's just check_cfg that's failing.
@Urgau It caught like two things that it should have caught and I almost missed them because it was squawking irrelevantly on all the nonsense like --cfg backtrace_in_libstd
.
I didn't design this crate's silliness, I just keep it running.
@ChrisDenton It looks like there's only one for the associated codegen option:
Ah, found it: https://github.com/rust-lang/reference/pull/1468
Thank you!
@Urgau It caught like two things that it should have caught and I almost missed them because it was squawking irrelevantly on all the nonsense like
--cfg backtrace_in_libstd
.
@workingjubilee This crate has already many build.rs
, you could have simply added the required cargo::check-check-cfg
instructions in it.
@Urgau I intend to delete this crate's main build.rs, so no.
@Urgau This crate only has a build.rs because Rust currently has tail-end Android legacy support that is not actually supported anymore upstream by the NDK. So, rust-lang/rust has a PR up to remove it, but that is blocked on rust's own CI. This crate never should have had a build.rs, and that will soon be fixed for good, and I will not merge another.
collapse_debuginfo
rustup update --no-self-update
consistently to avoid spurious CI errors