Don't cast HANDLE to usize and back

rust-lang / backtrace-rs

Backtraces in Rust

https://docs.rs/backtrace

Other

532 stars 245 forks source link

Don't cast HANDLE to usize and back #635

Closed CraftSpider closed 3 months ago

CraftSpider commented 3 months ago

Not sure if there's interest for this one - I'm aware of argument whether HANDLE really needs to be a pointer, and it's defined as isize for non-std mode bindgen, but it was an easy change so I figured I'd put it up for review.

ChrisDenton commented 3 months ago

The trouble there was using two or three different definitions of HANDLE in the same code. I can only assume it was written before we had AtomicPtr otherwise I don't understand why that wasn't used in the first place.