test cleanup for nightly

rust-lang / backtrace-rs

Backtraces in Rust

https://docs.rs/backtrace

Other

526 stars 245 forks source link

test cleanup for nightly #641

Closed workingjubilee closed 1 month ago

workingjubilee commented 1 month ago

A collage of random bugfixes.

format! now has #[must_use]: https://github.com/rust-lang/rust/pull/127355
miri randomizes inlineable fn addrs: https://github.com/rust-lang/rust/pull/123781
my own petard: https://github.com/rust-lang/rust/pull/125834
some permissive provenance warnings became louder and it's easier to just start fixing the provenance issues throughout the API than to try to wish them away, so we introduce TracePtr internally to help with this.

ChrisDenton commented 1 month ago

failures:

---- backtrace_new_should_start_with_call_site_trace stdout ----
  0: backtrace_new_should_start_with_call_site_trace

...they're the same picture???

workingjubilee commented 1 month ago

...yeah I have no idea why this is an unused_unsafe now :ferrisClueless:

            pub fn dbghelp(&self) -> *mut Dbghelp {
                unsafe {
                    ptr::addr_of_mut!(DBGHELP)
                }
            }

certainly someone didn't actually implement and merge https://github.com/rust-lang/rust/pull/125834

ChrisDenton commented 1 month ago

Ok after re-reviewing with coffee in hand, let's do this...

workingjubilee commented 1 month ago

Completely understandable. Thank you!