rust-lang / backtrace-rs

Backtraces in Rust
https://docs.rs/backtrace
Other
526 stars 245 forks source link

Update windows bindings and use windows-targets #653

Closed ChrisDenton closed 1 week ago

ChrisDenton commented 1 month ago

This synchronizes the API definitions with std. Trouble is, std uses its own definition of the windows_targets::link! macro so I've used a path hack to include it in this crate when used as a dependency of std. Otherwise the windows-targets crate is used.

Not sure if this will work but let's see what CI says.

ChrisDenton commented 1 month ago

Oh, path hacks might not work because it looks like there's a difference between fake-std and real-std.

ChrisDenton commented 1 month ago

Hmm... maybe I could make windows_targets crate in std's sysroot and share it that way.

ChrisDenton commented 3 weeks ago

Ok, with the std changes this should be ready for review now so removing the draft thingy

workingjubilee commented 2 weeks ago

merge conflicts

workingjubilee commented 2 weeks ago

Remember that libstd does this for backtrace-rs which allows adding hackery for libstd:

    println!("cargo:rustc-cfg=backtrace_in_libstd");