rust-lang / book

The Rust Programming Language
https://doc.rust-lang.org/book/
Other
14.9k stars 3.37k forks source link

mdbook build warnings: trpl-listing, trpl-note preprocessor #4018

Closed nathany closed 1 day ago

nathany commented 3 weeks ago

URL to the section(s) of the book with this problem:

Description of the problem:

❯ cargo install mdbook --locked --version 0.4.37

❯ mdbook build                                  
2024-08-19 19:07:07 [INFO] (mdbook::book): Book building has started
2024-08-19 19:07:07 [WARN] (mdbook::preprocess::cmd): The command wasn't found, is the "trpl-listing" preprocessor installed?
2024-08-19 19:07:07 [WARN] (mdbook::preprocess::cmd):   Command: mdbook-trpl-listing
2024-08-19 19:07:07 [WARN] (mdbook::preprocess::cmd): The command wasn't found, is the "trpl-note" preprocessor installed?
2024-08-19 19:07:07 [WARN] (mdbook::preprocess::cmd):   Command: mdbook-trpl-note
2024-08-19 19:07:07 [INFO] (mdbook::book): Running the html backend
echo $?
0

it looks like the build still works -- initially I thought it was an error -- but perhaps they are just warnings

macOS 14.6.1 latest commit #ddad34966e53508d769a0c844c4fb85b05914017

rustc 1.80.1 (3f5fd8dd4 2024-08-06) is installed, but rustc 1.79.0 in the the-rust-programming-language-manuscript folder

Suggested fix:

Not sure. Does the readme need an additional command?

nathany commented 3 weeks ago

Or maybe the readme should just say "The following warnings can be ignored safely." like the Rust By Example readme: https://github.com/rust-lang/rust-by-example?tab=readme-ov-file#using

chriskrycho commented 1 day ago

Thanks for the report – I’ll update the README with more up to date info for contributors here sometime this week!