search

rust-lang / bors

Rust implementation of bors used for various Rust components (e.g. the compiler).
Apache License 2.0
46 stars 20 forks source link

chore(deps): update secrecy 0.8.0 -> 0.10.3 #161

Closed alexpovel closed 1 month ago

alexpovel commented 1 month ago

I diffed the actual crates.io contents via

curl -L https://crates.io/api/v1/crates/secrecy/${VERSION}/download | tar -xf -

with VERSION as 0.8.0 and 0.10.3, then diffing via git. It revealed nothing suspicious, with changes as claimed per their CHANGELOG.md.

0.10.0 had some breaking changes. Secret<T> is no longer a thing, instead there's SecretBox<T>. It turned out secrecy usage in bors is limited, and private keys are fed as PEM-encoded Strings. For this, there's SecretString, which is just an alias for SecretBox<str>. Accepting it and converting to bytes in create_github_client simplifies code at the call sites a bit.

Kobzol commented 1 month ago

Thank you! :) PEM should hopefully be "just text", so UTF-8 encoding should handle it just fine.