Closed kraktus closed 2 years ago
CLI snapshots tests are failing on windows, I'll investigate but I think it's an issue with the test rather than with the behaviour
General note: I think I would prefer eyre
(with color-eyre
) over anyhow
, but that's not a strong requirement
CI fixed, and previous comments should have been addressed.
General note: I think I would prefer
eyre
(withcolor-eyre
) overanyhow
, but that's not a strong requirement
I am not familiar with the library, from what I see the difference is that it includes spantrace
. It will be a bit more noisy but considering our target are developers it should not be an issue. If we're good with leaving it by default, can make the switch.
Thanks!
I went ahead and merged it, since it can stand on its own.
Yea, using spantrace and being more developer focussed is good here, as failures in the tool are likely going to be debugged by users of the tool as you noted. Let's do that in a separate PR tho
No functional change
Replace deprecated/no-longer-maintained crates with a up-to-date replacement:
structopt
->clap
allowing for more validation to be done during arguments passingfailure
->thiserror
+anyhow
along with more tests and some refactoring.
this PR has maybe grown too big, and I can split it if needed, although efforts were made for it to be reviewed on a per-commit basis.