search

rust-lang / cargo-bisect-rustc

Bisects rustc, either nightlies or CI artifacts
https://rust-lang.github.io/cargo-bisect-rustc/
Apache License 2.0
174 stars 55 forks source link

Add custom "Satisfies" terms #316

Closed ehuss closed 1 month ago

ehuss commented 4 months ago

Request

Add --term-old and --term-new CLI options to customize the "Satisfies" terms.

Problem

Currently, cargo-bisect-rustc prints "Yes" or "No" (or new terms of #311) on whether or not a build satisfies the condition that it is looking for. However, this terminology is either confusing or backwards depending on what you are testing.

For example, you can use one of --regress options to find when a regression was fixed. In that sense, the "old" is "regression found" and the "new" is "regression fixed", which is backwards from the normal behavior.

Proposal

Taking inspiration from git bisect, I think it would be good to have custom terms for Satisfies. I think adding cli options like --term-old="compiled successfully" and --term-new="failed to compile" would allow the user to specify their own wording. Then, the --regress option could set the defaults for those terms appropriate for the regression type.

apiraino commented 2 months ago

@rustbot claim

I'm working on a patch

rustbot commented 2 months ago

Error: This repository is not enabled to use triagebot. Add a triagebot.toml in the root of the default branch to enable it.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.