search

rust-lang / cargo-bisect-rustc

Bisects rustc, either nightlies or CI artifacts
https://rust-lang.github.io/cargo-bisect-rustc/
Apache License 2.0
177 stars 55 forks source link

Stop stripping and LTO #334

Closed Noratrieb closed 5 months ago

Noratrieb commented 5 months ago

Stop stripping: Stripping symbols here is bad, because it makes the binary completely opaque and undebbuggable, should something ever go wrong. The binary size benefit is very minor, this program is supposed to run on desktop computers with tons of disk space. The tradeoff is bad.

I like to follow the rule of "do not ever strip symbols unless you absolutely need to", at least for programs on dev systems.

Stop LTO: The same binary size non-concerns as stripping apply. Also, speed basically doesn't matter here. Meanwhile, we want this program to be cargo install-able, so compile times matter. Again, the tradeoff is bad.

Noratrieb commented 5 months ago

If anyone cares about sacrificing things for 4 megabytes like in #157 they can always manually override the setting for their builds, this is just the default.

Noratrieb commented 5 months ago

@oli-obk you have approved the other pr