search

rust-lang / cargo-bisect-rustc

Bisects rustc, either nightlies or CI artifacts
https://rust-lang.github.io/cargo-bisect-rustc/
Apache License 2.0
178 stars 55 forks source link

Convert to default installation of cargo and replace `--with-cargo` option with `--without-cargo` option #98

Closed chrissimpkins closed 4 years ago

chrissimpkins commented 4 years ago

Closes #81

Also see the discussion in https://rust-lang.zulipchat.com/#narrow/stream/217417-t-compiler.2Fcargo-bisect-rustc/topic/unrecognized.20option.20json

This PR converts the --with-cargo optional behavior to default behavior to address Unrecognized option: 'json' errors in tests as bisection proceeds back in time past a defined date (I believe that this is ~ July 2019'ish era). The current default leads to incorrect automated detection of the regression commit due to this error. These changes also remove the --with-cargo option.

Edit: @spastorino recommended the addition of the --without-cargo flag to disable the cargo install in https://github.com/rust-lang/cargo-bisect-rustc/pull/98#issuecomment-644284958. This change was added in https://github.com/rust-lang/cargo-bisect-rustc/commit/2b7088c7f28fbf2dda7023a8fc30c092ab7764a1

spastorino commented 4 years ago

Looks good but I wonder if we do want a --without-cargo kind of flag to turn this off.

chrissimpkins commented 4 years ago

Looks good but I wonder if we do want a --without-cargo kind of flag to turn this off.

Anyone opposed to this? I'll add it this weekend if this is the only thing blocking the merge here.

chrissimpkins commented 4 years ago

Rebased on master @ https://github.com/rust-lang/cargo-bisect-rustc/pull/98/commits/c5e86ee1c72f061bfbaaf80978737baa4bc1e19f

chrissimpkins commented 4 years ago

--without-cargo flag added in 2b7088c7f28fbf2dda7023a8fc30c092ab7764a1

chrissimpkins commented 4 years ago

@spastorino Please let me know if there is anything else that you need for this PR. Thanks Santiago!