Closed cathaysia closed 4 months ago
Is anything blocking this?
Is anything blocking this?
I was working on something else, but generally I will response within a few hours.
Your PR generally looks good to me, just have a little bit to improve on, before merging it in.
Sometime env maybe a empty value, we should return None in this case: