search

rust-lang / cc-rs

Rust library for build scripts to compile C/C++ code into a Rust library
https://docs.rs/cc
Apache License 2.0
1.79k stars 434 forks source link

fix(env_tool): return None if env is empty #1021

Closed cathaysia closed 4 months ago

cathaysia commented 4 months ago

Sometime env maybe a empty value, we should return None in this case:

image

cathaysia commented 4 months ago

Is anything blocking this?

NobodyXu commented 4 months ago

Is anything blocking this?

I was working on something else, but generally I will response within a few hours.

Your PR generally looks good to me, just have a little bit to improve on, before merging it in.