search

rust-lang / cc-rs

Rust library for build scripts to compile C/C++ code into a Rust library
https://docs.rs/cc
Apache License 2.0
1.79k stars 434 forks source link

`1.0.91` update breaks `cargo-xwin` #1026

Closed namse closed 4 months ago

namse commented 4 months ago

related issue: https://github.com/rust-cross/cargo-xwin/issues/104

minimal reproducible example: https://github.com/namse/cc-rs-1.0.91-issue

Would you please check this problem?

NobodyXu commented 4 months ago

I think this is related to #1015 cc @russelltg

NobodyXu commented 4 months ago

@namse I've opened #1027 , can you please try it out?

namse commented 4 months ago

@NobodyXu Works very well I guess? image

namse commented 4 months ago

1.0.91 fails build on mimalloc crate image

but on cc = { git = "https://github.com/rust-lang/cc-rs.git", rev = "a03257af4a578cd2b7842b6109a6d817035d7a38" }, it build well (previous screenshot https://github.com/rust-lang/cc-rs/issues/1026#issuecomment-2042724521), the commit of https://github.com/rust-lang/cc-rs/pull/1027.

1.0.90 also good.

namse commented 4 months ago

Would you make a 1.0.92 tag to release to crate.io?

NobodyXu commented 4 months ago

Thanks, I've published the release