search

rust-lang / cc-rs

Rust library for build scripts to compile C/C++ code into a Rust library
https://docs.rs/cc
Apache License 2.0
1.77k stars 427 forks source link

Drop support for Visual Studio 12 (2013) #1046

Closed dpaoliello closed 6 days ago

dpaoliello commented 2 months ago

Visual Studio 2013 went out of support on Apr 9, 2024: https://learn.microsoft.com/en-us/lifecycle/products/visual-studio-2013

Additionally, the Rust Compiler has required Visual Studio 2017 since 1.66: https://github.com/rust-lang/rust/pull/102577/commits/9b3db34072551680c12da4192ad528a01579ce61

NobodyXu commented 2 months ago

It seems reasonable to drop vs 12, but I will wait for others' review in case they are against this change.

dpaoliello commented 2 months ago

@NobodyXu @thomcc any objections to merging this?

NobodyXu commented 1 month ago

As per zulip discussion, we decided to wait until msrv is bumped to 1.66

since the current msrv of cc still supports vs 12, merging it now might break some users.

Once msrv is bumped to 1.66, we will merge this.

NobodyXu commented 1 month ago

Discussion is in t-libs/crates, request review for cc-rs