Replace println with print_warning in Build::try_get_compiler

rust-lang / cc-rs

Rust library for build scripts to compile C/C++ code into a Rust library

https://docs.rs/cc

Apache License 2.0

1.77k stars 427 forks source link

Replace println with print_warning in Build::try_get_compiler #1051

Closed NobodyXu closed 2 months ago

NobodyXu commented 2 months ago

A println would not be seen by user unless -v is passed to cargo, using print_warning here makes more sense as user can see the message by default and also disable it if they don't want to see it.

thomcc commented 2 months ago

Hmm, isn't this a setting they requested? Why does it make sense to warn on things the user asks for?

NobodyXu commented 2 months ago

Hmm, isn't this a setting they requested? Why does it make sense to warn on things the user asks for?

Hmmm yeah...Maybe it makes more sense to remove this completely

NobodyXu commented 2 months ago

@thomcc I opened #1063 to remove the println