search

rust-lang / cc-rs

Rust library for build scripts to compile C/C++ code into a Rust library
https://docs.rs/cc
Apache License 2.0
1.87k stars 450 forks source link

`windows_registry::find_tool` failing in GitHub Actions windows runners since 1.0.84 #1071

Closed n8henrie closed 6 months ago

n8henrie commented 6 months ago

https://github.com/espanso/espanso uses cc in its build.rs, and it is a cross-platform (mac/linux/windows) app. It uses GitHub Actions with a native builder for CI, and I noticed some errors when building under the windows-latest (windows-2022) image.

I've narrowed down at least part of the problem in that it uses cc::windows_registry::find_tool to locate MSVC, and for some reason that stopped working.

I made a quick MRE at https://github.com/n8henrie/find-msvc -- it basically just runs assert!(find_tool("msvc", "devenv").is_some()).

I whipped up a quick sed script in a loop and ran it through available versions of cc, and it looks like it breaks at 1.0.84: (expand the set -x step): https://github.com/n8henrie/find-msvc/actions/runs/9044058093/job/24852304771

I'm not a Windows user normally, so this is a little murky for me, but I'm guessing this commit is the culprit.

I assume cc should be able to find MSVC when running in GitHub Actions... ?

NobodyXu commented 6 months ago

cc @ChrisDenton

ChrisDenton commented 6 months ago

I've not looked into it yet but I'd be surprised if that commit was the culprit. The success case should be exactly the same. That said, there could be some side effect I'm missing. I wrote that commit a long time ago even if it was only merged recently.

My only other quick thought is that find_tool("msvc", "devenv") does not contain a proper target. Maybe "msvc" used to happen to work but I'm not sure it was ever technically supported.

Anyway, I'll look into it properly when I have more time.

ChrisDenton commented 6 months ago

Ok, I had a look and it seems like find_tool("x86_64-pc-windows-msvc", "devenv") works as expected. In a build script you can just use the HOST environment variable (or TARGET in some specific cases).

Also find_tool("-msvc", "devenv") works but I wouldn't rely on that being stable either. The target argument is intended to be a full target name. Maybe we could have another function that means "find the Visual Studio directory" without looking up anything target specific but that's not what find_tool is intended for.

n8henrie commented 6 months ago

Hmmm, my MRE on GitHub Actions is still failing:

diff: https://github.com/n8henrie/find-msvc/commit/08793f15e6994da1f51aedfc864eca43042754c1 action run: https://github.com/n8henrie/find-msvc/actions/runs/9117099740/job/25067208750 direct link to the full log file

 curl -s 'https://productionresultssa14.blob.core.windows.net/actions-results/5ad9ab25-e2d2-40e0-b22c-2f5ce669b70e/workflow-job-run-ca395085-040a-526b-2ce8-bdc85f692774/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-05-16T18%3A32%3A22Z&sig=seaYDxtV0M4AXBshgsAF6LxJC6sgWgQxxitWRDDzM2Y%3D&sp=r&spr=https&sr=b&st=2024-05-16T18%3A22%3A17Z&sv=2021-12-02' |
    grep -e ' trying' -e 'test result:'
2024-05-16T18:08:45.2039523Z trying 1.0.66
2024-05-16T18:09:23.6924734Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.03s
2024-05-16T18:09:23.7111566Z trying 1.0.67
2024-05-16T18:09:25.5468325Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:25.5542673Z trying 1.0.68
2024-05-16T18:09:27.4029482Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:27.4095860Z trying 1.0.69
2024-05-16T18:09:29.1780720Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:29.1845930Z trying 1.0.70
2024-05-16T18:09:30.9865574Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:30.9935049Z trying 1.0.71
2024-05-16T18:09:32.8279486Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:32.8352265Z trying 1.0.72
2024-05-16T18:09:34.6271146Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:34.6342200Z trying 1.0.73
2024-05-16T18:09:36.4203295Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:36.4266786Z trying 1.0.74
2024-05-16T18:09:38.2815202Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:38.2884869Z trying 1.0.75
2024-05-16T18:09:40.1553478Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:40.1629380Z trying 1.0.76
2024-05-16T18:09:41.9913487Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:41.9982794Z trying 1.0.77
2024-05-16T18:09:43.8746798Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:43.8814730Z trying 1.0.78
2024-05-16T18:09:45.7343241Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:45.7415105Z trying 1.0.79
2024-05-16T18:09:47.6547481Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.06s
2024-05-16T18:09:47.6619532Z trying 1.0.80
2024-05-16T18:09:49.7866654Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:49.7934559Z trying 1.0.81
2024-05-16T18:09:51.8863173Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:51.8935809Z trying 1.0.82
2024-05-16T18:09:53.9553056Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:53.9621844Z trying 1.0.83
2024-05-16T18:09:56.1188601Z test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
2024-05-16T18:09:56.1257841Z trying 1.0.84
2024-05-16T18:09:56.2596253Z trying 1.0.85
2024-05-16T18:09:56.3872640Z trying 1.0.86
2024-05-16T18:09:58.7464251Z test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
2024-05-16T18:09:58.7524100Z trying 1.0.87
2024-05-16T18:10:01.1914443Z test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
2024-05-16T18:10:01.1971248Z trying 1.0.88
2024-05-16T18:10:03.4883875Z test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
2024-05-16T18:10:03.4945659Z trying 1.0.89
2024-05-16T18:10:05.9189134Z test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
2024-05-16T18:10:05.9247075Z trying 1.0.90
2024-05-16T18:10:08.1298387Z test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
2024-05-16T18:10:08.1357321Z trying 1.0.91
2024-05-16T18:10:10.3738657Z test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
2024-05-16T18:10:10.3801123Z trying 1.0.92
2024-05-16T18:10:12.5880442Z test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
2024-05-16T18:10:12.5915323Z trying 1.0.93
2024-05-16T18:10:15.4061855Z test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
2024-05-16T18:10:15.4119110Z trying 1.0.94
2024-05-16T18:10:17.6439216Z test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
2024-05-16T18:10:17.6497948Z trying 1.0.95
2024-05-16T18:10:19.9268735Z test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
2024-05-16T18:10:19.9324349Z trying 1.0.96
2024-05-16T18:10:22.1150471Z test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
2024-05-16T18:10:22.1209418Z trying 1.0.97
2024-05-16T18:10:24.5338124Z test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
n8henrie commented 6 months ago

It doesn't look like any of those env vars are set in this environment -- perhaps that's the problem? https://github.com/n8henrie/find-msvc/actions/runs/9117326651/job/25067918730

set -x
echo "$VSCMD_ARG_TGT_ARCH"
echo "$HOST"
echo "$TARGET"
shell: C:\Program Files\Git\bin\bash.EXE --noprofile --norc -e -o pipefail {0}
+ echo ''
+ echo ''
+ echo ''
n8henrie commented 6 months ago

Here is the env (again this is on a GitHub Actions windows-latest runner):

ProgramFiles(x86)=C:\Program Files (x86)
CommonProgramFiles(x86)=C:\Program Files (x86)\Common Files
SELENIUM_JAR_PATH=C:\selenium\selenium-server.jar
NUMBER_OF_PROCESSORS=4
PROCESSOR_LEVEL=25
CONDA=C:\Miniconda
CABAL_DIR=C:\cabal
GITHUB_WORKSPACE=D:\a\find-msvc\find-msvc
M2=C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7\bin
JAVA_HOME_11_X64=C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\11.0.23-9\x64
AZURE_CONFIG_DIR=C:\azureCli
PGROOT=C:\Program Files\PostgreSQL\14
ChromeWebDriver=C:\SeleniumWebDrivers\ChromeDriver
USERDOMAIN_ROAMINGPROFILE=fv-az972-524
IEWebDriver=C:\SeleniumWebDrivers\IEDriver
POWERSHELL_UPDATECHECK=Off
PROGRAMFILES=C:\Program Files
GITHUB_PATH=D:\a\_temp\_runner_file_commands\add_path_878d66b2-0f43-458a-a6b6-137d988f4290
GITHUB_ACTION=__run
MSYSTEM=MINGW64
ChocolateyInstall=C:\ProgramData\chocolatey
SBT_HOME=C:\Program Files (x86)\sbt\
PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
JAVA_HOME=C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.412-8\x64
GITHUB_RUN_NUMBER=23
RUNNER_NAME=GitHub Actions 6
GRADLE_HOME=C:\ProgramData\chocolatey\lib\gradle\tools\gradle-8.7
GITHUB_REPOSITORY_OWNER_ID=1234956
PGPASSWORD=root
OS=Windows_NT
ACTIONS_RUNNER_ACTION_ARCHIVE_CACHE=C:\actionarchivecache\
DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
HOMEDRIVE=C:
PGBIN=C:\Program Files\PostgreSQL\14\bin
ANT_HOME=C:\ProgramData\chocolatey\lib\ant\tools\apache-ant-1.10.14
JAVA_HOME_8_X64=C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.412-8\x64
GITHUB_TRIGGERING_ACTOR=n8henrie
GITHUB_REF_TYPE=branch
M2_REPO=C:\ProgramData\m2
USERDOMAIN=fv-az972-524
ANDROID_NDK=C:\Android\android-sdk\ndk\25.2.9519653
***
PIPX_BIN_DIR=C:\Program Files (x86)\pipx_bin
STATS_TRP=true
USERPROFILE=C:\Users\runneradmin
STATS_BLT=true
GOROOT_1_20_X64=C:\hostedtoolcache\windows\go\1.20.14\x64
GITHUB_REPOSITORY_ID=797464021
DEPLOYMENT_BASEPATH=C:\actions
GITHUB_ACTIONS=true
STATS_VMD=true
ANDROID_NDK_LATEST_HOME=C:\Android\android-sdk\ndk\26.3.11579264
GITHUB_SHA=56c6dfa58f8ff0f64a5c3d8bd4a4967236e6735d
GITHUB_WORKFLOW_REF=n8henrie/find-msvc/.github/workflows/ci.yml@refs/heads/master
POWERSHELL_DISTRIBUTION_CHANNEL=GitHub-Actions-win22
RUNNER_ENVIRONMENT=github-hosted
STATS_EXTP=https://provjobdsettingscdn.blob.core.windows.net/settings/provjobdsettings-0.5.172+1/provjobd.data
DOTNET_MULTILEVEL_LOOKUP=0
GITHUB_REF=refs/heads/master
ALLUSERSPROFILE=C:\ProgramData
RUNNER_OS=Windows
CommonProgramW6432=C:\Program Files\Common Files
GITHUB_REF_PROTECTED=false
HOME=/c/Users/runneradmin
USERNAME=runneradmin
GITHUB_API_URL=https://api.github.com
RUNNER_TRACKING_ID=github_0babf0a5-6fe1-4780-8140-0bc812861120
PLINK_PROTOCOL=ssh
RUNNER_ARCH=X64
GOROOT_1_21_X64=C:\hostedtoolcache\windows\go\1.21.10\x64
COMSPEC=C:\Windows\system32\cmd.exe
RUNNER_TEMP=D:\a\_temp
GITHUB_STATE=D:\a\_temp\_runner_file_commands\save_state_878d66b2-0f43-458a-a6b6-137d988f4290
PGUSER=postgres
MonAgentClientLocation=C:\Packages\Plugins\Microsoft.Azure.Geneva.GenevaMonitoring\2.44.0.5\Monitoring\Agent
APPDATA=C:\Users\runneradmin\AppData\Roaming
JAVA_HOME_21_X64=C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\21.0.3-9.0\x64
GITHUB_ENV=D:\a\_temp\_runner_file_commands\set_env_878d66b2-0f43-458a-a6b6-137d988f4290
SYSTEMROOT=C:\Windows
GITHUB_EVENT_PATH=D:\a\_temp\_github_workflow\event.json
STATS_D=true
GITHUB_EVENT_NAME=push
LOCALAPPDATA=C:\Users\runneradmin\AppData\Local
GITHUB_RUN_ID=9117451339
JAVA_HOME_17_X64=C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\17.0.11-9\x64
AZ_DEVOPS_GLOBAL_CONFIG_DIR=C:\azureDevOpsCli
RTOOLS44_HOME=C:\rtools44
ANDROID_NDK_HOME=C:\Android\android-sdk\ndk\25.2.9519653
GITHUB_STEP_SUMMARY=D:\a\_temp\_runner_file_commands\step_summary_878d66b2-0f43-458a-a6b6-137d988f4290
AZURE_DEVOPS_CACHE_DIR=C:\azureDevOpsCli\cache
COMPUTERNAME=fv-az972-524
GITHUB_ACTOR=n8henrie
GITHUB_RUN_ATTEMPT=1
STATS_RDCL=true
COBERTURA_HOME=C:\cobertura-2.1.1
ANDROID_HOME=C:\Android\android-sdk
GITHUB_GRAPHQL_URL=https://api.github.com/graphql
TERM=xterm-256color
LOGONSERVER=\\fv-az972-524
npm_config_prefix=C:\npm\prefix
STATS_UE=true
PSModulePath=C:\\Modules\azurerm_2.1.0;C:\\Modules\azure_2.1.0;C:\Users\packer\Documents\WindowsPowerShell\Modules;C:\Program Files\WindowsPowerShell\Modules;C:\Windows\system32\WindowsPowerShell\v1.0\Modules;C:\Program Files\Microsoft SQL Server\130\Tools\PowerShell\Modules\
WIX=C:\Program Files (x86)\WiX Toolset v3.14\
GITHUB_SERVER_URL=https://github.com
STATS_V3PS=true
PIPX_HOME=C:\Program Files (x86)\pipx
TEMP=/tmp
STATS_EXT=true
SHLVL=1
PROCESSOR_REVISION=0101
GeckoWebDriver=C:\SeleniumWebDrivers\GeckoDriver
DriverData=C:\Windows\System32\Drivers\DriverData
ANDROID_SDK_ROOT=C:\Android\android-sdk
VCPKG_INSTALLATION_ROOT=C:\vcpkg
GITHUB_ACTOR_ID=1234956
RUNNER_TOOL_CACHE=C:\hostedtoolcache\windows
ImageVersion=20240514.3.0
DOTNET_NOLOGO=1
GITHUB_WORKFLOW_SHA=56c6dfa58f8ff0f64a5c3d8bd4a4967236e6735d
COMMONPROGRAMFILES=C:\Program Files\Common Files
GITHUB_REF_NAME=master
GITHUB_JOB=build
EXEPATH=C:\Program Files\Git\bin
PROCESSOR_IDENTIFIER=AMD64 Family 25 Model 1 Stepping 1, AuthenticAMD
AZURE_EXTENSION_DIR=C:\Program Files\Common Files\AzureCliExtensionDirectory
PERFLOG_LOCATION_SETTING=RUNNER_PERFLOG
STATS_VMFE=true
GITHUB_REPOSITORY=n8henrie/find-msvc
GCM_INTERACTIVE=Never
EdgeWebDriver=C:\SeleniumWebDrivers\EdgeDriver
PGDATA=C:\Program Files\PostgreSQL\14\data
GOROOT_1_22_X64=C:\hostedtoolcache\windows\go\1.22.3\x64
ANDROID_NDK_ROOT=C:\Android\android-sdk\ndk\25.2.9519653
PHPROOT=c:\tools\php
MAVEN_OPTS=-Xms256m
GITHUB_RETENTION_DAYS=90
HOMEPATH=\Users\runneradmin
RUNNER_WORKSPACE=D:\a\find-msvc
GITHUB_ACTION_REPOSITORY=
TMP=/tmp
PATH=/mingw64/bin:/usr/bin:/c/Users/runneradmin/bin:/c/Program Files/MongoDB/Server/5.0/bin:/c/aliyun-cli:/c/vcpkg:/c/Program Files (x86)/NSIS:/c/tools/zstd:/c/Program Files/Mercurial:/c/hostedtoolcache/windows/stack/2.15.7/x64:/c/cabal/bin:/c/ghcup/bin:/c/mingw64/bin:/c/Program Files/dotnet:/c/Program Files/MySQL/MySQL Server 8.0/bin:/c/Program Files/R/R-4.4.0/bin/x64:/c/SeleniumWebDrivers/GeckoDriver:/c/SeleniumWebDrivers/EdgeDriver:/c/SeleniumWebDrivers/ChromeDriver:/c/Program Files (x86)/sbt/bin:/c/Program Files (x86)/GitHub CLI:/bin:/c/Program Files (x86)/pipx_bin:/c/npm/prefix:/c/hostedtoolcache/windows/go/1.21.10/x64/bin:/c/hostedtoolcache/windows/Python/3.9.13/x64/Scripts:/c/hostedtoolcache/windows/Python/3.9.13/x64:/c/hostedtoolcache/windows/Ruby/3.0.7/x64/bin:/c/Program Files/OpenSSL/bin:/c/tools/kotlinc/bin:/c/hostedtoolcache/windows/Java_Temurin-Hotspot_jdk/8.0.412-8/x64/bin:/c/Program Files/ImageMagick-7.1.1-Q16-HDRI:/c/Program Files/Microsoft SDKs/Azure/CLI2/wbin:/c/ProgramData/kind:/c/ProgramData/docker-compose:/c/ProgramData/Chocolatey/bin:/c/Windows/system32:/c/Windows:/c/Windows/System32/Wbem:/c/Windows/System32/WindowsPowerShell/v1.0:/c/Windows/System32/OpenSSH:/c/Program Files/dotnet:/c/Program Files/PowerShell/7:/c/Program Files/Microsoft/Web Platform Installer:/c/Program Files/Microsoft SQL Server/Client SDK/ODBC/170/Tools/Binn:/c/Program Files/Microsoft SQL Server/150/Tools/Binn:/c/Program Files (x86)/Windows Kits/10/Windows Performance Toolkit:/c/Program Files (x86)/WiX Toolset v3.14/bin:/c/Program Files/Microsoft SQL Server/130/DTS/Binn:/c/Program Files/Microsoft SQL Server/140/DTS/Binn:/c/Program Files/Microsoft SQL Server/150/DTS/Binn:/c/Program Files/Microsoft SQL Server/160/DTS/Binn:/c/Strawberry/c/bin:/c/Strawberry/perl/site/bin:/c/Strawberry/perl/bin:/c/ProgramData/chocolatey/lib/pulumi/tools/Pulumi/bin:/c/Program Files/TortoiseSVN/bin:/c/Program Files/CMake/bin:/c/ProgramData/chocolatey/lib/maven/apache-maven-3.8.7/bin:/c/Program Files/Microsoft Service Fabric/bin/Fabric/Fabric.Code:/c/Program Files/Microsoft SDKs/Service Fabric/Tools/ServiceFabricLocalClusterManager:/c/Program Files/nodejs:/cmd:/mingw64/bin:/usr/bin:/c/Program Files/GitHub CLI:/c/tools/php:/c/Program Files (x86)/sbt/bin:/c/Program Files/Amazon/AWSCLIV2:/c/Program Files/Amazon/SessionManagerPlugin/bin:/c/Program Files/Amazon/AWSSAMCLI/bin:/c/Program Files/Microsoft SQL Server/130/Tools/Binn:/c/Program Files/LLVM/bin:/c/Users/runneradmin/.dotnet/tools:/c/Users/runneradmin/.cargo/bin:/c/Users/runneradmin/AppData/Local/Microsoft/WindowsApps
RUNNER_PERFLOG=C:\actions\perflog
GITHUB_BASE_REF=
ProgramW6432=C:\Program Files
GHCUP_INSTALL_BASE_PREFIX=C:\
CI=true
ImageOS=win22
STATS_D_D=true
GITHUB_REPOSITORY_OWNER=n8henrie
GITHUB_HEAD_REF=
GITHUB_ACTION_REF=
PSModuleAnalysisCachePath=C:\PSModuleAnalysisCachePath\ModuleAnalysisCache
WINDIR=C:\Windows
GITHUB_WORKFLOW=CI
PROCESSOR_ARCHITECTURE=AMD64
PUBLIC=C:\Users\Public
GHCUP_MSYS2=C:\msys64
GITHUB_OUTPUT=D:\a\_temp\_runner_file_commands\set_output_878d66b2-0f43-458a-a6b6-137d988f4290
MSYS=disable_pcon
SYSTEMDRIVE=C:
ProgramData=C:\ProgramData
ChrisDenton commented 6 months ago

Here's the test I was using: https://github.com/ChrisDenton/cc-test/blob/fefe50390d4c45d346f00f54b509c84f223397ad/src/main.rs

And the results: https://github.com/ChrisDenton/cc-test/actions/runs/9117607103/job/25068848745

n8henrie commented 6 months ago

Thanks -- embarrassingly, I only changed the target for main but not for the tests, which I suspect is the problem 🤦

n8henrie commented 6 months ago

Indeed it does: https://github.com/n8henrie/find-msvc/actions/runs/9117737219/job/25069287124

Thank you @ChrisDenton!

ChrisDenton commented 6 months ago

No problem! I'm glad your problem got fixed.