search

rust-lang / cc-rs

Rust library for build scripts to compile C/C++ code into a Rust library
https://docs.rs/cc
Apache License 2.0
1.79k stars 434 forks source link

Bump msrv to 1.67 #1143

Closed NobodyXu closed 1 month ago

NobodyXu commented 1 month ago

For #1137

TheBlueMatt commented 1 month ago

Does this crate have a documented MSRV policy anywhere? It seems strange to me to bump to 1.67 (breaking any crates which support building on Debian) in a patch version in such a core ecosystem crate.

NobodyXu commented 1 month ago

We are discussing this on zulip https://rust-lang.zulipchat.com/#narrow/stream/351149-t-libs.2Fcrates/topic/cc-rs.20MSRV.20policy

We'd like to hear from others, on their expected MSRV requirements for cc

NobodyXu commented 1 month ago

(breaking any crates which support building on Debian)

It seems that Debian already vendors the cc crate, they have an old version of cc

https://packages.debian.org/stable/rust/librust-cc+jobserver-dev

TheBlueMatt commented 1 month ago

It seems that Debian already vendors the cc crate, they have an old version of cc

This is unrelated to people building crates on Debian using cargo. For those who want x-lang LTO or to use a toolchain that is built on the same machines as the rest of their host crates pulled by cargo need to support 1.63.

NobodyXu commented 1 month ago

For those who want x-lang LTO or to use a toolchain that is built on the same machines as the rest of their host crates pulled by cargo need to support 1.63.

Thanks, that's a scenario I didn't consider.

Is it possible to pin the cc version via Cargo.lock?

TheBlueMatt commented 1 month ago

Ah, I'd already responded at https://github.com/rust-lang/cc-rs/issues/1144#issuecomment-2214271486 we can continue there to keep things in one place.