search

rust-lang / cc-rs

Rust library for build scripts to compile C/C++ code into a Rust library
https://docs.rs/cc
Apache License 2.0
1.79k stars 434 forks source link

Add empty `jobserver` feature. #1150

Closed waywardmonkeys closed 1 month ago

waywardmonkeys commented 1 month ago

Since we removed implicit features, anyone that used this crate and specifically enabled jobserver would now be broken as this crate no longer had that feature (or a couple of others).

Add a placeholder jobserver feature that doesn't enable parallel (just as it didn't enable it before).

The other features removed weren't likely to be enabled by anyone.

waywardmonkeys commented 1 month ago

This should fix the problem reported in #1099 by @rafales.

The actual problem should also be reported to the @solana-labs crew.

waywardmonkeys commented 1 month ago

I reported it and the issue was auto-closed as the whole thing has been forked. I looked in the fork and it no longer uses cc ... but since this was technically part of the public API, this change is still fine to go in, I guess.