Closed dpaoliello closed 6 months ago
FYI, @NobodyXu @ChrisDenton
Is there anyway of preventing such breakage by adding regression tests?
Added.
@NobodyXu can we please get a release with this fix, I believe it's the only blocker left to updating cc-rs in the Rust toolchain
Created release, waiting for publish
The
--target
argument should not be passed to Clang when targeting Android, as the Android NDK contains wrappers for Clang that automatically set the target.However, https://github.com/rust-lang/cc-rs/commit/53564e00498156c9be00361c4b039952cbf7ff59 introduced a regression where
--target
was being passed on non-Windows platforms, which broke thecompile-ui
tests for the Rust compiler when building forarm-android
: https://github.com/rust-lang/rust/pull/121854#issuecomment-1973518078This fix restores the original logic AND respects the new
has_internal_target_arg
flag (regardless if we're targeting Android or not).I've verified that the
arm-android
build succeeds with this change: https://github.com/rust-lang/rust/actions/runs/8146073082/job/22263762750?pr=121874Fixes #990