search

rust-lang / chalk

An implementation and definition of the Rust trait system using a PROLOG-like logic solver
https://rust-lang.github.io/chalk/book/
Other
1.84k stars 182 forks source link

Make various methods on InferenceTable public #718

Closed flodiebold closed 3 years ago

flodiebold commented 3 years ago

I don't see a reason for them to be pub(crate), and especially the snapshot/rollback functionality is necessary for rust-analyzer.

I made some other functions more private that are only used from their modules.

jackh726 commented 3 years ago

@bors r+

bors commented 3 years ago

:pushpin: Commit 5442f5eebe1b52dfa3f61e9d4c31a410202c3fbb has been approved by jackh726

bors commented 3 years ago

:hourglass: Testing commit 5442f5eebe1b52dfa3f61e9d4c31a410202c3fbb with merge 9456600c1649ef6aad9a7a2e38312185047ec509...

bors commented 3 years ago

:sunny: Test successful - checks-actions Approved by: jackh726 Pushing 9456600c1649ef6aad9a7a2e38312185047ec509 to master...