search

rust-lang / chalk

An implementation and definition of the Rust trait system using a PROLOG-like logic solver
https://rust-lang.github.io/chalk/book/
Other
1.81k stars 180 forks source link

CI Publish job using Mac runner #721

Closed AzureMarker closed 3 years ago

AzureMarker commented 3 years ago

I noticed while putting together #720 that the publish job is run under macos-latest. @pksunkara is this intentional? I don't see why we can't use a Linux runner, since those are more plentiful/standard.

pksunkara commented 3 years ago

I had some issues getting the sed working on Ubuntu.

AzureMarker commented 3 years ago

Since we're not using the sed anymore, I'll try switching it to ubuntu.

Edit: oh, there is one still to extract the version. I'll see if it works and convert it if necessary.