search

rust-lang / chalk

An implementation and definition of the Rust trait system using a PROLOG-like logic solver
https://rust-lang.github.io/chalk/book/
Other
1.81k stars 180 forks source link

Make DispatchFromDyn a well-known type #738

Closed nrc closed 2 years ago

nrc commented 2 years ago

The first commit is some minor refactoring. The second commit does the 'obvious' work of making DispatchFromDyn well-known. In order to properly enforce the wf-ness constraints on DispatchFromDyn, Chalk needs to know about one-zst types, that is in the next commit. The final commit finishes the DispatchFromDyn work by enforcing the WF-ness constraints and adding tests.

r? @jackh726

jackh726 commented 2 years ago

Awesome :) I'll try to get to reviewing this soon.

There's also either an issue or checkbox somewhere that needs to be changed after this is merged 😉

jackh726 commented 2 years ago

@bors delegate+

bors commented 2 years ago

:v: @nrc can now approve this pull request

nrc commented 2 years ago

@bors r+

bors commented 2 years ago

:pushpin: Commit e92db1dfb4661b6a78c70c3f86c5e089e7879f2c has been approved by nrc

bors commented 2 years ago

:hourglass: Testing commit e92db1dfb4661b6a78c70c3f86c5e089e7879f2c with merge 4b95a894b8395f670f959e224d5f0ad58a642e8c...

bors commented 2 years ago

:sunny: Test successful - checks-actions Approved by: nrc Pushing 4b95a894b8395f670f959e224d5f0ad58a642e8c to master...