Fix clippy warnings - Githubissues

rust-lang / chalk

An implementation and definition of the Rust trait system using a PROLOG-like logic solver

https://rust-lang.github.io/chalk/book/

Other

1.84k stars 182 forks source link

Closed Kinrany closed 2 years ago

Kinrany commented 2 years ago

This PR contains:

Trivial Clippy fixes such as needless_borrow, redundant_clone, match_like_matches_macro, try_err, needless_return, ...
Small local refactors, which I will point out in comments.

Each type of change is in a separate commit, except for the last commit that has a mix of unique changes.

The 18 remaining clippy errors are a bit more substantial.

jackh726 commented 2 years ago

@bors r+

Thanks!

bors commented 2 years ago

:pushpin: Commit b38fb85151a40cb3e0bc4d3814bae14a27d64d50 has been approved by jackh726

bors commented 2 years ago

:hourglass: Testing commit b38fb85151a40cb3e0bc4d3814bae14a27d64d50 with merge f470f2f493203f58d493c7221863bca2ce1a6dad...

bors commented 2 years ago

:sunny: Test successful - checks-actions Approved by: jackh726 Pushing f470f2f493203f58d493c7221863bca2ce1a6dad to master...