Rename folding/visiting traits

rust-lang / chalk

An implementation and definition of the Rust trait system using a PROLOG-like logic solver

https://rust-lang.github.io/chalk/book/

Other

1.81k stars 179 forks source link

Closed eggyal closed 2 years ago

eggyal commented 2 years ago

Align the names of chalk's folding/visiting traits with those in rustc (especially once rust-lang/rust#98206) is merged.

r? @jackh726

eggyal commented 2 years ago

Apologies for the force-push there. I tried to reorder the commits but it completely messed up the branch; didn't notice before pushing.

Failing test is due to broken doc links but this commit will update those docs? Test should probably be against revised documentation, no?

detrumi commented 2 years ago

Failing test is due to broken doc links but this commit will update those docs? Test should probably be against revised documentation, no?

This was just fixed, so just ignore it in this PR.

jackh726 commented 2 years ago

@bors r+

bors commented 2 years ago

:pushpin: Commit 23d39c90ceb9242fbd4c43e9368e813e7c2179f7 has been approved by jackh726

bors commented 2 years ago

:hourglass: Testing commit 23d39c90ceb9242fbd4c43e9368e813e7c2179f7 with merge ebdb87ca0ba0cf89b292fbad59c32548b5914556...

bors commented 2 years ago

:sunny: Test successful - checks-actions Approved by: jackh726 Pushing ebdb87ca0ba0cf89b292fbad59c32548b5914556 to master...