rust-lang / chalk

An implementation and definition of the Rust trait system using a PROLOG-like logic solver
https://rust-lang.github.io/chalk/book/
Other
1.85k stars 182 forks source link

Remove unused Result assoc type from Fold trait #768

Closed eggyal closed 2 years ago

eggyal commented 2 years ago

r? @jackh726

eggyal commented 2 years ago

Broken doc links look good from here, but evidently not working in CI.

detrumi commented 2 years ago

Doc links are fixed now. No need to retry the build since the main build succeeded already.

jackh726 commented 2 years ago

@bors delegate+

bors commented 2 years ago

:v: @eggyal can now approve this pull request

jackh726 commented 2 years ago

After #767 lands, this will need a rebase. LGTM

bors commented 2 years ago

:umbrella: The latest upstream changes (presumably #767) made this pull request unmergeable. Please resolve the merge conflicts.

eggyal commented 2 years ago

Rebased.

jackh726 commented 2 years ago

@bors r+

bors commented 2 years ago

:pushpin: Commit a9d086c9ff14e77b3004ec30b085ddcb2a900d17 has been approved by jackh726

bors commented 2 years ago

:hourglass: Testing commit a9d086c9ff14e77b3004ec30b085ddcb2a900d17 with merge 4991b7d0f9ff6f2017df2a2ff2039134cba80431...

bors commented 2 years ago

:sunny: Test successful - checks-actions Approved by: jackh726 Pushing 4991b7d0f9ff6f2017df2a2ff2039134cba80431 to master...