search

rust-lang / chalk

An implementation and definition of the Rust trait system using a PROLOG-like logic solver
https://rust-lang.github.io/chalk/book/
Other
1.81k stars 179 forks source link

Implement should_continue in chalk-recursive #774

Closed detrumi closed 1 year ago

detrumi commented 2 years ago

This just returns NoSolution if it shouldn't continue, but that should already be useful to rust-analyzer.

Note: Cloning of should_continue is a workaround to a rustc bug (#95734)

detrumi commented 2 years ago

Build failed because of #775

detrumi commented 1 year ago

Alright, changed it to Ok(Ambig). As for refactoring, would it be useful to add Solution::QuantumExceeded, like AnswerResult::QuantumExceeded in chalk-engine?

jackh726 commented 1 year ago

Alright, changed it to Ok(Ambig). As for refactoring, would it be useful to add Solution::QuantumExceeded, like AnswerResult::QuantumExceeded in chalk-engine?

yeah probably

@bors r+

bors commented 1 year ago

:pushpin: Commit f6ac6f5534d4cb91180782ddac7570956ccc1ffe has been approved by jackh726

It is now in the queue for this repository.

bors commented 1 year ago

:hourglass: Testing commit f6ac6f5534d4cb91180782ddac7570956ccc1ffe with merge 75aa6cf2c69ba5590ff74228d4192bbee0259619...

bors commented 1 year ago

:sunny: Test successful - checks-actions Approved by: jackh726 Pushing 75aa6cf2c69ba5590ff74228d4192bbee0259619 to master...