update syn to 2.0 - Githubissues

rust-lang / chalk

An implementation and definition of the Rust trait system using a PROLOG-like logic solver

https://rust-lang.github.io/chalk/book/

Other

1.85k stars 182 forks source link

update syn to 2.0 #793

Closed fee1-dead closed 1 year ago

jackh726 commented 1 year ago

@bors r+

bors commented 1 year ago

:pushpin: Commit 9233e54a0efd09c60afa454444e5bd19d518c8ec has been approved by jackh726

It is now in the queue for this repository.

bors commented 1 year ago

:hourglass: Testing commit 9233e54a0efd09c60afa454444e5bd19d518c8ec with merge a618c6cc00f03910d7d34aa26380b8abbe2d6035...

bors commented 1 year ago

:sunny: Test successful - checks-actions Approved by: jackh726 Pushing a618c6cc00f03910d7d34aa26380b8abbe2d6035 to master...

lqd commented 1 year ago

Interesting, this adds syn 2 but doesn't remove syn 1. Do you know if other dependencies have also switched to syn 2 and released a new version already ? Will syn be duplicated in rustc as well ?

compiler-errors commented 1 year ago

Dependencies that introduce syn:

tracing v0.1.29
salsa-macros v0.16.0 (via salsa v0.16.0)
string_cache v0.8.2 (via serde-derive v1.0.130, via serde v1.0.130)

so those will need to be upgraded

davidbarsky commented 1 year ago

tracing v0.1.29

Yeah, I'm (pretty sure) we're on it.

lqd commented 1 year ago

I found the rustc tracking issue for this migration, with the other dependencies introducing syn and requiring upgrades there, at https://github.com/rust-lang/rust/issues/109302.