Closed lowr closed 1 year ago
@bors r+
:pushpin: Commit 5ffee10b889be5fa05a2c37fa88b98162e603934 has been approved by jackh726
It is now in the queue for this repository.
:lock: Merge conflict
This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.
:umbrella: The latest upstream changes (presumably #780) made this pull request unmergeable. Please resolve the merge conflicts.
I'll rebase this one after #792 lands as it's likely to cause another conflict.
@bors r+
:pushpin: Commit 52b52cf67229d799b5adc292334f0551f2dc6afa has been approved by jackh726
It is now in the queue for this repository.
:hourglass: Testing commit 52b52cf67229d799b5adc292334f0551f2dc6afa with merge e856e214eef45a03724db6dd6c3501f7841c5dc7...
:sunny: Test successful - checks-actions Approved by: jackh726 Pushing e856e214eef45a03724db6dd6c3501f7841c5dc7 to master...
Currently, we don't generate clauses for placeholder associated types (
TyKind::AssociatedType
) except for someFromEnv
s. This leads toNoSolution
for goals like(IntoIterator::IntoIter)<Opaque>: Iterator
whereOpaque = impl IntoIterator
.For every associated type in a trait definition
chalk with this patch generates
To be honest, I'm not entirely sure if
AssociatedTyDatum::to_program_clauses()
is the best place to generate those clauses in, but analogous clauses for placeholder opaque types are generated inOpaqueTyDatum::to_program_clauses()
, which I modeled after.Spotted in rust-lang/rust-analyzer#14680.