rust-lang / chalk

An implementation and definition of the Rust trait system using a PROLOG-like logic solver
https://rust-lang.github.io/chalk/book/
Other
1.81k stars 179 forks source link

Pin cargo-workspaces to 0.2.44 #799

Closed HKalbasi closed 1 year ago

HKalbasi commented 1 year ago

The publish action was failing due some problem in the cargo-workspaces (see this zulip thread). The problem is now solved, so this PR is not necessary and just triggering the publish again should work, but this PR pin it to the current version to prevent similar problems in future.

lqd commented 1 year ago

An update of proc-macro2 will also be needed, to fix building on nightly.

lqd commented 1 year ago

Thanks! Hopefully it unblocks r-a if it's still needed.

(Let's see if bors is correctly set up for contributors.)

@bors r+

bors commented 1 year ago

@lqd: :key: Insufficient privileges: Not in reviewers

lqd commented 1 year ago

We'll need the help of e.g. @compiler-errors 🙏

compiler-errors commented 1 year ago

looks fine to me, hope this makes the release work ✅

@bors r+

bors commented 1 year ago

:pushpin: Commit ac7374ffe824cb0d15094b088ee028a75514f2a2 has been approved by compiler-errors

It is now in the queue for this repository.

bors commented 1 year ago

:hourglass: Testing commit ac7374ffe824cb0d15094b088ee028a75514f2a2 with merge 7e8d539307488de7bb7afe2c41e2bfbde36b0775...

bors commented 1 year ago

:sunny: Test successful - checks-actions Approved by: compiler-errors Pushing 7e8d539307488de7bb7afe2c41e2bfbde36b0775 to master...

HKalbasi commented 1 year ago

@compiler-errors Can you also manually trigger the publish action?

compiler-errors commented 1 year ago

I have no idea how to do that, or if I even have the permissions to do that. Maybe @jackh726 knows and can do it, but I think it's probably worth waiting a few days for the autopublish (it's on sundays, right?)

HKalbasi commented 1 year ago

In https://github.com/rust-lang/chalk/actions/workflows/publish.yml you will see a Run workflow button if you have access:

image

But waiting on sunday is also fine, there is no hurry.

compiler-errors commented 1 year ago

https://github.com/rust-lang/chalk/actions/runs/5425813938