Closed HKalbasi closed 1 year ago
An update of proc-macro2 will also be needed, to fix building on nightly.
Thanks! Hopefully it unblocks r-a if it's still needed.
(Let's see if bors is correctly set up for contributors.)
@bors r+
@lqd: :key: Insufficient privileges: Not in reviewers
We'll need the help of e.g. @compiler-errors 🙏
looks fine to me, hope this makes the release work ✅
@bors r+
:pushpin: Commit ac7374ffe824cb0d15094b088ee028a75514f2a2 has been approved by compiler-errors
It is now in the queue for this repository.
:hourglass: Testing commit ac7374ffe824cb0d15094b088ee028a75514f2a2 with merge 7e8d539307488de7bb7afe2c41e2bfbde36b0775...
:sunny: Test successful - checks-actions Approved by: compiler-errors Pushing 7e8d539307488de7bb7afe2c41e2bfbde36b0775 to master...
@compiler-errors Can you also manually trigger the publish action?
I have no idea how to do that, or if I even have the permissions to do that. Maybe @jackh726 knows and can do it, but I think it's probably worth waiting a few days for the autopublish (it's on sundays, right?)
In https://github.com/rust-lang/chalk/actions/workflows/publish.yml you will see a Run workflow
button if you have access:
But waiting on sunday is also fine, there is no hurry.
The publish action was failing due some problem in the
cargo-workspaces
(see this zulip thread). The problem is now solved, so this PR is not necessary and just triggering the publish again should work, but this PR pin it to the current version to prevent similar problems in future.