rust-lang / cmake-rs

Rust build dependency for running cmake
https://docs.rs/cmake
Apache License 2.0
301 stars 121 forks source link

Disable some targets where zlib-ng seems to no longer compile with default flags #164

Closed thomcc closed 1 year ago

thomcc commented 1 year ago

zlib-ng seems to need some extra flags to work on armv7 (to enable neon) or ppc64 (to enable altivec), so it's not really a great test case. I'll look into a better fix this weekend, but for now I'd prefer to just disable these, since the failures are effectively spurious.

I think a nice fix in the future might be if we passed along the flags needed based on CARGO_CFG_TARGET_FEATURES? I haven't thought about this much, so perhaps this is out of place for cmake-rs.

See also #80, where this was added. For whatever reason, that PR didn't have the same issues (older version of zlib-ng?)