search

rust-lang / cmake-rs

Rust build dependency for running cmake
https://docs.rs/cmake
Apache License 2.0
301 stars 121 forks source link

Revert #110 to fix iOS cross-compilation after #158. Fixes #173 #176

Closed luser closed 1 year ago

luser commented 1 year ago

In #158, better support for using CMake's cross-compilation facilities was added. This made the workaround added in #110 for iOS not only unnecessary, but actively harmful, in that it runs afoul of SDK validation checks in the CMake iOS codepath.

This PR removes the workaround (reverting #110) and also adds a CI job to test an iOS cross-compile.

luser commented 1 year ago

I pushed the CI change without the revert, and it failed which was good because it reproduced the problem: https://github.com/luser/cmake-rs/actions/runs/4025276950/jobs/6918367203

luser commented 1 year ago

The iOS cross-compile job succeeds in CI now.