Closed SoulSharer closed 1 year ago
There are several places where i686
checked as well. However I hesitated to change them, since I can't test these paths.
If it's clearly a target_arch check feel free to include it in the PR. That's never a valid value for CARGO_CFG_TARGET_ARCH
But I think this code might have places where it pulls something out of env::var("TARGET")?.split('-')
. But I might be thinking of something else.
Just rechecked, that seems to be true, it does extract i686 from a supplied triplet. PR should be good as is then.
Was trying to cross-compile
nng 1.0.1
crate withcargo build --target i686-pc-windows-gnu
. It failed becausecmake
crate did not properly setCMAKE_SYSTEM_NAME
define due to a failed match on target arch. Target supplied byCARGO_CFG_TARGET_ARCH
is noti686
butx86
. Additional reference used: https://doc.rust-lang.org/reference/conditional-compilation.html#target_arch.