Fix cross compilation on android armv7 and x86

rust-lang / cmake-rs

Rust build dependency for running cmake

https://docs.rs/cmake

Apache License 2.0

301 stars 121 forks source link

Fix cross compilation on android armv7 and x86 #186

Closed fredszaq closed 3 weeks ago

fredszaq commented 11 months ago

This fixes the following cmake errors

Android: Unknown processor CMAKE_SYSTEM_PROCESSOR='x86'.

and

Android: Unknown processor CMAKE_SYSTEM_PROCESSOR='arm'.

when crosscompiling for i686-linux-android and armv7-linux-androideabi android targets

fixes #175

fredszaq commented 11 months ago

the ci fails on mips crosscompile test as rustup can't download those targets that were retrogaded to tier 3 https://github.com/rust-lang/compiler-team/issues/648

FlorianDenis commented 10 months ago

I confirm this solves issues cross-compiling for Android, would love to see this merged

MihirLuthra commented 8 months ago

Yes, this solves the issue (I can confirm for armv7-linux-androideabi) @thomcc, pinging you since you seem to be an active reviewer of cmake-rs 🙂. Please ignore if this PR falls out of your scope.