rust-lang / cmake-rs

Rust build dependency for running cmake
https://docs.rs/cmake
Apache License 2.0
301 stars 121 forks source link

Honor `no_default_flags` setting #189

Closed christianheussy closed 11 months ago

christianheussy commented 11 months ago

Problem: init_c_cfg permits the user to set a cc::Build configuration. The setting for no_default_flags is always overridden by uses_android_sdk. This prevents a user from building with no_default_flags = true.

Solution: Do not override no_default_flags value. In the event uses_android_sdk returns true, continue to set no_default_flags to true. Note that no_default_flags defaults to false.

Issue: https://github.com/rust-lang/cmake-rs/issues/188