Fix ios cross compilation

rust-lang / cmake-rs

Rust build dependency for running cmake

https://docs.rs/cmake

Apache License 2.0

301 stars 121 forks source link

Closed FlorianDenis closed 2 weeks ago

FlorianDenis commented 9 months ago

Make sure CMAKE_OSX_ARCHITECTURES gets defined for iOS if not user-supplied (extending existing logic for macOS)
Make sure CMAKE_OSX_SYSROOT gets defined as well

tgross35 commented 3 weeks ago

@FlorianDenis would you be able to resolve conflicts for this? I think this looks good otherwise, but @madsmtm could you confirm?

FlorianDenis commented 2 weeks ago

You are asking for conflict resolution on a 10 line PR that got ignored for 8 months?

tgross35 commented 2 weeks ago

This crate had a lapse in maintenance as you noticed, really the only thing we can do at this point is attempt to get it merged now.

If you are uninterested in continuing then I (or perhaps @madsmtm) can pick up your work and reapply it.

FlorianDenis commented 1 week ago

Feel free to pick up the work and try to get it merged 👍