rust-lang / cmake-rs

Rust build dependency for running cmake
https://docs.rs/cmake
Apache License 2.0
301 stars 121 forks source link

Cmake-rs does not work with custom CC_{TARGET} environment variables that uses arguments. #201

Open richarddd opened 7 months ago

richarddd commented 7 months ago

Arguments are not applied when setting a custom CC or CXX variable:

[env]
CC_aarch64_unknown_linux_musl = "zig cc -target aarch64-linux-musl"
CXX_aarch64_unknown_linux_musl = "zig cc -target aarch64-linux-musl"
CC_x86_64_unknown_linux_musl = "zig cc -target x86_64-linux-musl"
CXX_x86_64_unknown_linux_musl = "zig cc -target x86_64-linux-musl"

In https://github.com/rust-lang/cmake-rs/blob/c4a60dd154dd90e469dffc41a1faa717704f90b3/src/lib.rs#L745C36-L745C52 we only apply args and not wrapper_args.

Maybe instead use https://docs.rs/cc/latest/cc/struct.Tool.html#method.to_command and then get all the args from there because that includes wrapper args.