search

rust-lang / compiler-team

A home for compiler team planning documents, meeting minutes, and other such things.
https://rust-lang.github.io/compiler-team/
Apache License 2.0
387 stars 69 forks source link

Dealing with disabled tests #540

Open pnkfelix opened 2 years ago

pnkfelix commented 2 years ago

Meeting proposal info

Summary

We sometimes disable tests because some other component we don't control (e.g. LLVM) is causing them to fail; see e.g. https://github.com/rust-lang/rust/issues/99853

But we should put structures/protocols in place to ensure that such tests are revisited in the future, rather than just lying unaddressed.

About this issue

This issue corresponds to a meeting proposal for the compiler team steering meeting. It corresponds to a possible topic of discussion. You can read more about the steering meeting procedure here.

Comment policy

These issues are meant to be used as an "announcements channel" regarding the proposal, and not as a place to discuss the technical details. Feel free to subscribe to updates. We'll post comments when reviewing the proposal in meetings or making a scheduling decision. In the meantime, if you have questions or ideas, ping the proposers on Zulip (or elsewhere).

apiraino commented 2 years ago

Also mention of https://github.com/rust-lang/rust/issues/88520 as another example (iiuc the context of that issue)

lqd commented 2 years ago

Is the following in scope for that meeting: is it possible to ensure these optional components' tests are indeed executed on CI ? (Or is that more of a t-infra concern). I'm thinking of the needs-lld tests in particular, that we currently can run locally but not on CI.