rustbot
commented
2 months ago This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:
@rustbot concern reason-for-concern
<description of the concern> Concerns can be lifted with:
@rustbot resolve reason-for-concern See documentation at https://forge.rust-lang.org
cc @rust-lang/compiler @rust-lang/compiler-contributors
Proposal
Our policy is currently to add new flags under
-Zor using-Zunstable-optionsprior to stabilisation. Typically the latter is only used when extending an existing already stable flag (e.g. a new argument for-Csplit-debuginfo), and-Zis used for entirely new flags.Presumably, the convention of using
-Zcame about from wanting to avoid users depending on unstable flags, but it ends up causing churn for those projects which need depend on an unstable flags which will soon be stabilised, such as Rust for Linux - once a flag is stabilised, as all of its uses need to be updated from-Zto the new stable flag and failure to do so could cause various CI breakages and other such hassle.We should change our policy so that new flags are added as they are intended to be stabilised, but require
-Zunstable-optionsto use. For example, instead of adding-Zfixed-x18, instead add-Cfixed-x18and require-Zunstable-options.-Zwould be reserved for never-stable flags such as-Ztreat-err-as-bug.-Zunstable-optionsis currently a blanket approval for any unstable feature that is gated behind it, this may or may not make sense as it is used more, but whether or not to require features be explicitly enabled by arguments to-Zunstable-optionsis left to a follow-up MCP.Mentors or Reviewers
@oli-obk @nikomatsakis
Process
The main points of the Major Change Process are as follows:
@rustbot second.-C flag, then full team check-off is required.@rfcbot fcp mergeon either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.