rust-lang / crater

Run experiments across parts of the Rust ecosystem!
https://crater.rust-lang.org
636 stars 88 forks source link

Cargo should not allow crates to tread on the target directory #183

Open aidanhs opened 6 years ago

aidanhs commented 6 years ago

The tests for tarpaulin run cargo clean, which nukes the target directory.

https://github.com/xd009642/tarpaulin/blob/083fec9ef018dd38516d1929b0fbedf06042fd60/src/lib.rs#L109

aidanhs commented 6 years ago

@pietroalbini does run-graph fix this by not sharing the target dir? My memory fails me...

pietroalbini commented 6 years ago

@aidanhs it sort of reduces the impact, because there are NUM_THREADS target directories instead of one for each toolchain. The solution for this is to lock the target directory while running tests, which should not cause too much trouble (tests are built before).