search

rust-lang / crater

Run experiments across parts of the Rust ecosystem!
https://crater.rust-lang.org
643 stars 90 forks source link

Crater skips repositories with a Cargo.toml but not Cargo.lock #548

Open Aaron1011 opened 4 years ago

Aaron1011 commented 4 years ago

When data/github.csv is read, only repositories with both a Cargo.toml and a Cargo.lock are tested:

https://github.com/rust-lang/crater/blob/dcc54566d5ec82cabca435c0145cbd06f32d3602/src/crates/sources/github.rs#L44-L47

Based on the comment, it looks like the intention was to test repositories with just a Cargo.lock or Cargo.toml as well.

This resulted in a Crater run failing to detect a regression in https://github.com/rust-lang/rust/issues/77718. While Crater cannot be expected to catch all regressions, I think it would be a good idea to test these kinds of repositories. Hopefully, doing so doesn't lead to a significant increase in job run time.

pietroalbini commented 4 years ago

The intention of that condition was to filter out libraries already published on crates.io, as there is usually little point in testing multiple versions of the same library. I think it's fine to remove the condition if we implement a more advanced one that still filters out crates published on crates.io.