search

rust-lang / crater

Run experiments across parts of the Rust ecosystem!
https://crater.rust-lang.org
643 stars 90 forks source link

Skip mpsc channels in report generation and disk cleaning #567

Closed Mark-Simulacrum closed 3 years ago

Mark-Simulacrum commented 3 years ago

I doubt this is the cause of our deadlocks, but std's mpsc channels have had some bugs in the past around timeouts IIRC. In any case, the new implementation feels just simpler to me, so an improvement regardless.

bors commented 3 years ago

:umbrella: The latest upstream changes (presumably #568) made this pull request unmergeable. Please resolve the merge conflicts.

pietroalbini commented 3 years ago

Thanks!

@bors r+

bors commented 3 years ago

:pushpin: Commit 3726b8b4e0a0b9ce7a9336cabb8a2d81e49a3454 has been approved by pietroalbini

bors commented 3 years ago

:hourglass: Testing commit 3726b8b4e0a0b9ce7a9336cabb8a2d81e49a3454 with merge aaafc9c6808fa3d76b490deaa6173c3a5c5df20b...

bors commented 3 years ago

:broken_heart: Test failed - checks-actions

Mark-Simulacrum commented 3 years ago

@bors r=pietroalbini

bors commented 3 years ago

:pushpin: Commit edd87b74bf4b5ae6b7ba50ddd917c8a9441c6163 has been approved by pietroalbini

bors commented 3 years ago

:hourglass: Testing commit edd87b74bf4b5ae6b7ba50ddd917c8a9441c6163 with merge c05fd09bafbacd59a4c77de6fdbaed4d45d66d31...

bors commented 3 years ago

:sunny: Test successful - checks-actions Approved by: pietroalbini Pushing c05fd09bafbacd59a4c77de6fdbaed4d45d66d31 to master...