search

rust-lang / crater

Run experiments across parts of the Rust ecosystem!
https://crater.rust-lang.org
643 stars 90 forks source link

Retry timeout #596

Closed Mark-Simulacrum closed 2 years ago

Mark-Simulacrum commented 2 years ago

https://github.com/rust-lang/rust/pull/92413#issuecomment-1008140371 failed due to a request timeout, plausibly because of a parallel request (e.g., metrics) which locked out the database for long enough to cause a failure. This changes our retry logic to hopefully always retry timed out requests.

(It does not take the step we took with docker builds of unilaterally retrying all requests, but that may be a better path rather than trying to guess... for now this seems a more limited answer).

Mark-Simulacrum commented 2 years ago

@bors r+

bors commented 2 years ago

:pushpin: Commit a2f3b39e795790b909683219f352ae0e6dd25ded has been approved by Mark-Simulacrum

bors commented 2 years ago

:hourglass: Testing commit a2f3b39e795790b909683219f352ae0e6dd25ded with merge 774de591955679c082c23e665f72cd3504656ff8...

bors commented 2 years ago

:sunny: Test successful - checks-actions Approved by: Mark-Simulacrum Pushing 774de591955679c082c23e665f72cd3504656ff8 to master...