search

rust-lang / crater

Run experiments across parts of the Rust ecosystem!
https://crater.rust-lang.org
639 stars 90 forks source link

Bump libgit2-sys version to be compatible with systems that have newer libgit2 #598

Closed saethlin closed 2 years ago

saethlin commented 2 years ago

cargo run -- prepare-local doesn't work at the moment on Arch/Manjaro, because rolling release distros are shipping libgit 1.3.0, which has a compatability break (intentional or not it's unclear) since 1.1.0. libgit2-sys will build a vendored version if the system version is too old, but not if it is too new. So with this change, the build should be correct on all systems.

I'm running into the same error as https://github.com/rustsec/rustsec/issues/431 and applying the fix suggested therein.

Mark-Simulacrum commented 2 years ago

Can you say whether this is a problem if the system is old? (Including quite old -- some of our servers with Crater running on them are on pretty old LTS distributions these days).

saethlin commented 2 years ago

This PR bumps the required libgit2 version from 1.1.0 to 1.3.0. The libgit2-sys crate compiles a vendored libgit2 version is if the system version is too old. So as far as I can tell, on any LTS Ubuntu, the distro version of libgit2 was already too old (they only ship 0.28 at best). So those servers should already be building a vendored libgit2, this patch would just change the version that the builds are vendoring.

Mark-Simulacrum commented 2 years ago

@bors r+

bors commented 2 years ago

:pushpin: Commit 3cafbf25ac95c8fcdb1de16a9a9068be543ad33a has been approved by Mark-Simulacrum

bors commented 2 years ago

:hourglass: Testing commit 3cafbf25ac95c8fcdb1de16a9a9068be543ad33a with merge 0c572ab1dd26664ec848e4741f02cc03b3581c80...

bors commented 2 years ago

:sunny: Test successful - checks-actions Approved by: Mark-Simulacrum Pushing 0c572ab1dd26664ec848e4741f02cc03b3581c80 to master...