search

rust-lang / crater

Run experiments across parts of the Rust ecosystem!
https://crater.rust-lang.org
643 stars 90 forks source link

Add cargoflags to toolchain configuration #626

Closed willcrichton closed 2 years ago

willcrichton commented 2 years ago

I am trying to test the new scrape examples feature using Crater. Because it's gated behind a Cargo flag -Zrustdoc-scrape-examples, I added the ability for Crater to take as input a new +cargoflags=... configuration for toolchains, similar to how +rustflags works.

One possible implementation issue: I'm doing cargoflags.split(' ') to split up the provided flags so as to pass them into the command builder. A more robust method would be to use a crate like shlex. I'm not sure if this is important enough to add the dependency, or if there's a better way to do this.

Mark-Simulacrum commented 2 years ago

@bors r+

I don't think we need to bother with shlex or similar -- if that becomes an issue, I'd rather change the encoding such that we can specify flags via the DB or something and just manually adjust when necessary or so.

bors commented 2 years ago

:pushpin: Commit 250680bbe7ea389fbabddc2256b8b34fc1ee6b8d has been approved by Mark-Simulacrum

bors commented 2 years ago

:hourglass: Testing commit 250680bbe7ea389fbabddc2256b8b34fc1ee6b8d with merge 34be8a11a6a2eab961046ad195805c820f4aeac1...

bors commented 2 years ago

:sunny: Test successful - checks-actions Approved by: Mark-Simulacrum Pushing 34be8a11a6a2eab961046ad195805c820f4aeac1 to master...