search

rust-lang / crater

Run experiments across parts of the Rust ecosystem!
https://crater.rust-lang.org
629 stars 88 forks source link

Rework getting next crate to be per-worker, rather than a global queue #650

Closed Mark-Simulacrum closed 2 years ago

Mark-Simulacrum commented 2 years ago

The previous commit added the notion of timeouts on retrieved crates from the server, which meant that when an agent (which has multiple workers) requested the 1024 crates from the server, the tail of that request would likely have timed out by the time the agent started/completed working on those crates. This isn't technically a problem, but it is likely to lead to duplicated work for that tail which is a performance issue, so we avoid it by retrieving crates one at a time with the new commit.

Mark-Simulacrum commented 2 years ago

@bors r+

bors commented 2 years ago

:pushpin: Commit f193cf0afcbe24905c7e5a308b56285a53626eed has been approved by Mark-Simulacrum

bors commented 2 years ago

:hourglass: Testing commit f193cf0afcbe24905c7e5a308b56285a53626eed with merge 3b9bbc9da4c994099682f52c2b88fb7ae9c421ee...

Mark-Simulacrum commented 2 years ago

@bors r

Mark-Simulacrum commented 2 years ago

@bors r+

bors commented 2 years ago

:pushpin: Commit d99ee660935bc79a027036cbd17e96e03932cdc7 has been approved by Mark-Simulacrum

bors commented 2 years ago

:hourglass: Testing commit d99ee660935bc79a027036cbd17e96e03932cdc7 with merge f2b24d245d8df920150629b2c79f2cf22c42fbf3...

bors commented 2 years ago

:sunny: Test successful - checks-actions Approved by: Mark-Simulacrum Pushing f2b24d245d8df920150629b2c79f2cf22c42fbf3 to master...