rust-lang / crater

Run experiments across parts of the Rust ecosystem!
https://crater.rust-lang.org
629 stars 88 forks source link

Check disk space more often #653

Closed Mark-Simulacrum closed 2 years ago

Mark-Simulacrum commented 2 years ago

Currently seeing a high rate of failure in git clone due to disk space limits being exhausted, which is presumably due to this check not running often enough, though we don't have great evidence for that. With current instance disk space (100 GB) we would need to always grow slower than 15GB in 5 minutes (roughly 3GB/minute), which seems like it should be reasonable, but maybe isn't.

The new bound is every 30 seconds, and we'd need to grow 20 GB in that time, which seems very unlikely.

It's likely also worth exploring a retry strategy for error'd crates, but that'll take more design work to make sure we do eventually complete.

Mark-Simulacrum commented 2 years ago

@bors r+

bors commented 2 years ago

:pushpin: Commit b37750583e91106f11c5fa6791c5ed7b2233f8a3 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors commented 2 years ago

:hourglass: Testing commit b37750583e91106f11c5fa6791c5ed7b2233f8a3 with merge f26d27a4ffafb01519d977d064642eecf27949e7...

Mark-Simulacrum commented 2 years ago

@bors r+

bors commented 2 years ago

:pushpin: Commit 96e63b8956ddd15c03572e42acfdc42f44377b56 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors commented 2 years ago

:hourglass: Testing commit 96e63b8956ddd15c03572e42acfdc42f44377b56 with merge b140bb1c8e743dcd1150966c29a713dee49c2c07...

bors commented 2 years ago

:sunny: Test successful - checks-actions Approved by: Mark-Simulacrum Pushing b140bb1c8e743dcd1150966c29a713dee49c2c07 to master...