search

rust-lang / crater

Run experiments across parts of the Rust ecosystem!
https://crater.rust-lang.org
629 stars 88 forks source link

Enable retries in the SDK #658

Closed Mark-Simulacrum closed 2 years ago

Mark-Simulacrum commented 2 years ago

It sounds like the previous definition for the SdkConfig would fail to configure a sleep impl, and currently that means that we're just silently not retrying any requests. This is obviously not what we want, and likely explains the repeated errors we saw on https://github.com/rust-lang/rust/pull/99389 when generating the report.

Mark-Simulacrum commented 2 years ago

@bors r+

bors commented 2 years ago

:pushpin: Commit a29aa236bc4b1cfe74c3cbe228551a3c61a8fa23 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors commented 2 years ago

:hourglass: Testing commit a29aa236bc4b1cfe74c3cbe228551a3c61a8fa23 with merge b2c5d9a0c707f8f88683dd40285e33c4ae54b539...

bors commented 2 years ago

:sunny: Test successful - checks-actions Approved by: Mark-Simulacrum Pushing b2c5d9a0c707f8f88683dd40285e33c4ae54b539 to master...