search

rust-lang / crater

Run experiments across parts of the Rust ecosystem!
https://crater.rust-lang.org
627 stars 88 forks source link

Distinct build directories per toolchain #681

Closed Mark-Simulacrum closed 1 year ago

Mark-Simulacrum commented 1 year ago

We see a number of failures from build scripts or tests failing when run in the same directory. These are 99% likely to be bugs in that crate, but Crater's goal isn't to find bugs in crates but bugs/regressions in rustc, so we should try to avoid sharing a build directory as we did before.

In practice this additional level of nesting should be minimally impactful in terms of cache hits, as caching across toolchains wasn't possible anyway. It may even improve things.

Our purging algorithm is the same as before.

Mark-Simulacrum commented 1 year ago

@bors r+

bors commented 1 year ago

:pushpin: Commit c58a1fc0c520f36866d0a42148b638afdb31282e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors commented 1 year ago

:hourglass: Testing commit c58a1fc0c520f36866d0a42148b638afdb31282e with merge 1814fe73afae0f5903296764f8b0822090448cad...

bors commented 1 year ago

:sunny: Test successful - checks-actions Approved by: Mark-Simulacrum Pushing 1814fe73afae0f5903296764f8b0822090448cad to master...