search

rust-lang / crater

Run experiments across parts of the Rust ecosystem!
https://crater.rust-lang.org
627 stars 88 forks source link

Avoid panicking on negative durations #697

Closed Mark-Simulacrum closed 1 year ago

Mark-Simulacrum commented 1 year ago

This currently causes a panic when loading a run's details page after it has finished the initial processing (but not yet completed log uploads, I think?).

Mark-Simulacrum commented 1 year ago

@bors r+

bors commented 1 year ago

:pushpin: Commit ea9341fb83642ab07f65f9f15c2ecec3df4cd84e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors commented 1 year ago

:hourglass: Testing commit ea9341fb83642ab07f65f9f15c2ecec3df4cd84e with merge 3cbbd88e65ec30c8dffc5fe53785f5c28875c54c...

bors commented 1 year ago

:broken_heart: Test failed - checks-actions

Mark-Simulacrum commented 1 year ago

@bors r+

bors commented 1 year ago

:pushpin: Commit 73798108fa37b55802a1d931e344e526fe55a05b has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors commented 1 year ago

:hourglass: Testing commit 73798108fa37b55802a1d931e344e526fe55a05b with merge e4849d8ae0065ce6bda8ec5a6d3aff122356f122...

bors commented 1 year ago

:broken_heart: Test failed - checks-actions

Mark-Simulacrum commented 1 year ago

@bors r+

bors commented 1 year ago

:pushpin: Commit 8b3f0598d32b89188dac2c00d28569b11c8de64a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors commented 1 year ago

:hourglass: Testing commit 8b3f0598d32b89188dac2c00d28569b11c8de64a with merge a4339c452908fedcd3791df5852db9ee94c34ada...

bors commented 1 year ago

:broken_heart: Test failed - checks-actions

Mark-Simulacrum commented 1 year ago

OK -- I think the CI failure here is because of -Zno-index-update, which is incompatible with the sparse index. It used to be that a single index fetch was enough, because it contained all crates, but that's no longer true.

I'm not sure yet if we should just stop passing it or instead configure Cargo to use the git index.

Mark-Simulacrum commented 1 year ago

@bors r+

bors commented 1 year ago

:pushpin: Commit 2f13d9f62b7fe9f65251b6e3543220824f9138ee has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors commented 1 year ago

:hourglass: Testing commit 2f13d9f62b7fe9f65251b6e3543220824f9138ee with merge 48c666aeadb550896a8962052b0dbe44df7841c8...

bors commented 1 year ago

:sunny: Test successful - checks-actions Approved by: Mark-Simulacrum Pushing 48c666aeadb550896a8962052b0dbe44df7841c8 to master...