Closed lqd closed 4 months ago
@bors r+
This seems reasonable to me.
:pushpin: Commit aedec6d80d9fdba33160d5b81e5fd93b624b4ca0 has been approved by Mark-Simulacrum
It is now in the queue for this repository.
:hourglass: Testing commit aedec6d80d9fdba33160d5b81e5fd93b624b4ca0 with merge a00f6b3739991d6b337130311bc769f17c59777f...
:broken_heart: Test failed - checks-actions
@bors r+
:bulb: This pull request was already approved, no need to approve it again.
retry
to trigger a build again.:pushpin: Commit aedec6d80d9fdba33160d5b81e5fd93b624b4ca0 has been approved by Mark-Simulacrum
It is now in the queue for this repository.
:hourglass: Testing commit aedec6d80d9fdba33160d5b81e5fd93b624b4ca0 with merge f2a10b4a604952d9434cecdbd42f46efd6b24757...
:sunny: Test successful - checks-actions Approved by: Mark-Simulacrum Pushing f2a10b4a604952d9434cecdbd42f46efd6b24757 to master...
:sunny: Test successful - checks-actions Approved by: Mark-Simulacrum Pushing f2a10b4a604952d9434cecdbd42f46efd6b24757 to master...
:eyes: Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.
This PR forbids unprefixed SHAs for toolchain arguments, to avoid crater hanging when they appear.
I'm not sure this is fully valid though: I don't know if SHAs could appear in a
Toolchain
's name (andRustwideToolchain::dist()
) without being an error 😓. This commonly happens withrustup-toolchain-install-master
but I don't know if a similar situation could arise within common crater usage.CI will surely fail: some of the used dependencies are broken on nightly right now, and clippy emits warnings -- both issues are fixed in #722.
(this is for @oli-obk and for @compiler-errors)