search

rust-lang / crater

Run experiments across parts of the Rust ecosystem!
https://crater.rust-lang.org
627 stars 88 forks source link

prioritize `NoSpace` error more #729

Closed Skgland closed 1 day ago

Skgland commented 2 months ago

Replacement for #715

adjust the prioritization of NoSpace

After this it will be prioritized above

The later two are already spurious-regressions so only the reason will change. The former two would previously result in a regression but now would be spurious-regressions. I think this change is reasonable as no space will likely be the cause for the compiler error or the error in the dependency.

include the spurious regressions in the retry-regressed-list.txt

Spurious failures might hide actual regressions, this gives them another chance at showing actual regressions. Further more spurious regressions are usually not too many and re-running will in a lot of cases resolve the spurious failure.

Sort some CommandError::IO(_) into as better FailureReason

Skgland commented 2 months ago

Looks like time 0.3.30 is broken

   Compiling memoffset v0.9.0
error[E0282]: type annotations needed for `Box<_>`
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.30/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

    Checking bitflags v2.4.1
bors commented 2 days ago

:umbrella: The latest upstream changes (presumably #732) made this pull request unmergeable. Please resolve the merge conflicts.

bors commented 1 day ago

:umbrella: The latest upstream changes (presumably #734) made this pull request unmergeable. Please resolve the merge conflicts.

Mark-Simulacrum commented 1 day ago

@bors r+

bors commented 1 day ago

:pushpin: Commit 397f3f09f7625438a2ea3bbbd85b73d7b85838fd has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors commented 1 day ago

:hourglass: Testing commit 397f3f09f7625438a2ea3bbbd85b73d7b85838fd with merge bdd7be9080b825ad91e6b72336503a411dbe8e20...

bors commented 1 day ago

:sunny: Test successful - checks-actions Approved by: Mark-Simulacrum Pushing bdd7be9080b825ad91e6b72336503a411dbe8e20 to master...